🤖 fix: use ResultSchema for sendMessage output to prevent field stripping #773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ping
Zod's z.union() tries schemas in order and returns the first match.
The sendMessage output had ResultSchema(z.void()) first, which matched
{success: true} and stripped workspaceId/metadata as "extra keys" before
the workspace creation schema could match.
Fixed by using a single ResultSchema with optional workspaceId/metadata
fields instead of a union, ensuring consistent response shape.
Change-Id: Id55f726d7814d75f03169dfd5fa35bd0e4c38886
Signed-off-by: Thomas Kosiewski <tk@coder.com>
ethanndickson
added a commit
that referenced
this pull request
Nov 28, 2025
Reverts: - 470e4eb perf: fix streaming content delay from ORPC schema validation (#774) - b437977 feat: add backend support for soft-interrupts (#767) - df30cbc fix: use ResultSchema for sendMessage output to prevent field stripping (#773) - 41c77ef fix: testUtils formatting (#771) - 3ee7288 refactor: migrate IPC layer to ORPC for type-safe RPC (#763)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
Reverts: - 470e4eb perf: fix streaming content delay from ORPC schema validation (#774) - b437977 feat: add backend support for soft-interrupts (#767) - df30cbc fix: use ResultSchema for sendMessage output to prevent field stripping (#773) - 41c77ef fix: testUtils formatting (#771) - 3ee7288 refactor: migrate IPC layer to ORPC for type-safe RPC (#763) Due to a huge number of regressions. _Generated with `mux`_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
z.union()was matchingResultSchema(z.void())first, which strippedworkspaceId/metadataas "extra keys"ResultSchemausing optional fields for consistent response shapeTest plan
make typecheckpassesuseCreationWorkspace.test.tsxtests passGenerated with
mux